This repository was archived by the owner on Jun 10, 2024. It is now read-only.
fix: version numbers (#138) #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
commented
Jun 25, 2021
| When make a GET request to "/" | ||
| Then the response status code should be 200 | ||
| And the response should be "Welcome to EddieHub! Currently running version: v0.0.0" | ||
| # And the response should be "Welcome to EddieHub! Currently running version: v0.0.0" |
There was a problem hiding this comment.
We need an issue for this! Would anyone like a green square 🟩
There was a problem hiding this comment.
Issue raised here #141
naomi-lgbt
approved these changes
Jun 25, 2021
SashoStoichkov
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Looks great :) Amazing collaboration @eddiejaoude @Cahllagerfeld
Done on stream: https://www.youtube.com/watch?v=F6mLySx9Kzc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138