IDEA(dbal): A set of interfaces for constructing queries #7562
Conversation
These interfaces allow us to construct most basic queries within Elgg in a programmatic and safe way. Have not attempted to find out where the more complicated entities queries could be converted to this, but it does seem pretty generic and able to handle quite a range, so I would be remiss not to try. The major downside of all this of course is that it would be mostly custom implementation. The main attempt at "innovation" is using pass-by-reference to alias tables instead of strings. This guarantees that all aliases are unique and allows you to refer to columns/tables in the query by references rather than strings.
|
This looks fine. I'm a little meh on the ROI of rolling our own vs pulling in Doctrine DBAL. I'm not sure SQL is a big problem for us, and to the people that need help writing valid SQL I'd prefer to teach SQL. |
|
If we had a simpler mechanism for auto-prefixing tables (like Drupal's) our queries would be significantly more readable. I believe Drupal has to parse queries to do this however. |
|
Don't forget the ability to rewrite in various SQL dialects (actually... I think I'm also looking forward to not needing all the sanitize string and On Sat, Nov 29, 2014, 4:05 PM Steve Clay notifications@github.com wrote:
|
Added some more comments to Elgg\Database\* classes to demonstrate intended conversion
…Statement (which feels like the easiest one to start with).
|
Too much overhead. Not enough benefit |
These interfaces allow us to construct most basic queries within Elgg
in a programmatic and safe way. Have not attempted to find out where
the more complicated entities queries could be converted to this,
but it does seem pretty generic and able to handle quite a range, so
I would be remiss not to try.
The major downside of all this of course is that it would be mostly custom
implementation. The main attempt at "innovation" is using pass-by-reference
to alias tables instead of strings. This guarantees that all aliases are unique
and allows you to refer to columns/tables in the query by references rather
than strings.
I didn't look outside of doctrine for a query builder interface but if you know any others that might be close to this, that would be appreciated. Hopefully there is enough documentation here to give the gist of the API and generate some good discussion.