Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix direction and alignment issue in rtl languages #9

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fix direction and alignment issue in rtl languages #9

merged 1 commit into from
Apr 16, 2019

Conversation

nekofar
Copy link
Contributor

@nekofar nekofar commented Apr 15, 2019

No description provided.

@AndiDittrich
Copy link
Member

thanks @nekofar

one question: are programming languages always expressed ltr even rtl is used for text ? sorry for that stupid question but im not familiar with rtl languages

@nekofar
Copy link
Contributor Author

nekofar commented Apr 15, 2019 •
edited
Loading

thanks @nekofar

one question: are programming languages always expressed ltr even rtl is used for text ? sorry for that stupid question but im not familiar with rtl languages

As far as I know, we do not have any right to left programming language. The programming languages ​​are all left-to-right.
When the admin panel is on a right to left language (Arabic, Persian, Hebrew, etc), all blocks are displayed right to left which is annoying.

@AndiDittrich
Copy link
Member

thank you! i'll also changes this within the TinyMCE plugin

@AndiDittrich AndiDittrich merged commit 27214fb into EnlighterJS:master Apr 16, 2019
@AndiDittrich AndiDittrich added bug Something isn't working enhancement New feature or request labels Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekofar @AndiDittrich