Skip to content

Fix issue when ontology and terms api returns different terms numbering. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

Fix issue when ontology and terms api returns different terms numbering. #40

merged 1 commit into from
Sep 19, 2019

Conversation

marcoooo
Copy link
Contributor

Since OLS api calls return different values for number of terms, we need to double check actual terms slice boundaries.
Done.

@marcoooo marcoooo self-assigned this Sep 19, 2019
@marcoooo marcoooo added the bug Something isn't working label Sep 19, 2019
@marcoooo marcoooo added this to the Ensembl 99 milestone Sep 19, 2019
@james-monkeyshines james-monkeyshines merged commit f90f3b7 into release/99 Sep 19, 2019
@james-monkeyshines james-monkeyshines deleted the bugfixes/99 branch September 19, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@james-monkeyshines james-monkeyshines james-monkeyshines approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@marcoooo marcoooo

Labels
bug Something isn't working
Projects
None yet
Milestone
Ensembl 99
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoooo @james-monkeyshines