Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scikit GradientBoostingClassifier with XGBClassifier #83

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Replace scikit GradientBoostingClassifier with XGBClassifier #83

merged 2 commits into from
Feb 19, 2016

Conversation

tcfuji
Copy link
Contributor

@tcfuji tcfuji commented Feb 17, 2016

Also includes a test and dependency in setup.py.

@tcfuji
Copy link
Contributor Author

tcfuji commented Feb 18, 2016

@rhiever I'm not too familiar with travis. Should I just add pip install xgboost==$XGBOOST_VERSION to .travis_install?

@rhiever
Copy link
Contributor

rhiever commented Feb 18, 2016

I believe you need to do the following. @rasbt can confirm.

@rasbt
Copy link
Contributor

rasbt commented Feb 18, 2016

I am not using boosting and don't know if XGBoost has any other dependencies. However, if it can be installed via pip install xgboost then the steps Randy outlined above are the way to go. Maybe set up a fresh virtual environment with numpy, scipy, and scikit-learn installed and test if pip install xgboost is sufficient or if you need something like pip install xgboost -r requirements.txt

@rhiever
Copy link
Contributor

rhiever commented Feb 18, 2016

Thanks @rasbt! You should give XGBoost a try. Even without OpenMP, it seems to be streets ahead of regular gradient boosting.

@rasbt
Copy link
Contributor

rasbt commented Feb 18, 2016

You are welcome! I dunno, someday maybe, but I feel like XGBoost is more of a ML competition / Kaggle thing :P . Currently, I am more excited about toying around with TensorFlow :)

@rhiever
Copy link
Contributor

rhiever commented Feb 18, 2016

To each their own. If you look at the examples above, XGBoost is very easy to use. Same interface as sklearn models. I hope the sklearn team will integrate XGBoost soon.

@rhiever
Copy link
Contributor

rhiever commented Feb 18, 2016

@tcfuji: Will review this tomorrow. Looks good from a high-level glance.

rhiever pushed a commit that referenced this pull request Feb 19, 2016
Replace scikit GradientBoostingClassifier with XGBClassifier
@rhiever rhiever merged commit 0fad36a into EpistasisLab:master Feb 19, 2016
@rhiever
Copy link
Contributor

rhiever commented Feb 19, 2016

Looks good. Thanks again @tcfuji!

@rhiever
Copy link
Contributor

rhiever commented Feb 19, 2016

@tcfuji, when you get a moment, can you please submit a separate PR to update the docs? Currently, they say we still use the sklearn GBC. We need to update that.

The docs are located here.

You can view the docs as you change them by running mkdocs serve in the docs directory. (This will require you to pip install mkdocs if you haven't already.)

@rhiever
Copy link
Contributor

rhiever commented Feb 19, 2016

I think we should simply remove the sklearn GBC entry and make a new entry for XGBoost. You can likely use the sklearn GBC entry as a template so the changes will be minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants