-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace scikit GradientBoostingClassifier with XGBClassifier #83
Conversation
…t and install requirement
@rhiever I'm not too familiar with travis. Should I just add |
I believe you need to do the following. @rasbt can confirm.
|
I am not using boosting and don't know if XGBoost has any other dependencies. However, if it can be installed via |
Thanks @rasbt! You should give XGBoost a try. Even without OpenMP, it seems to be streets ahead of regular gradient boosting. |
You are welcome! I dunno, someday maybe, but I feel like XGBoost is more of a ML competition / Kaggle thing :P . Currently, I am more excited about toying around with TensorFlow :) |
To each their own. If you look at the examples above, XGBoost is very easy to use. Same interface as sklearn models. I hope the sklearn team will integrate XGBoost soon. |
change test
@tcfuji: Will review this tomorrow. Looks good from a high-level glance. |
Replace scikit GradientBoostingClassifier with XGBClassifier
Looks good. Thanks again @tcfuji! |
@tcfuji, when you get a moment, can you please submit a separate PR to update the docs? Currently, they say we still use the sklearn GBC. We need to update that. The docs are located here. You can view the docs as you change them by running |
I think we should simply remove the sklearn GBC entry and make a new entry for XGBoost. You can likely use the sklearn GBC entry as a template so the changes will be minimal. |
Also includes a test and dependency in
setup.py
.