-
Notifications
You must be signed in to change notification settings - Fork 1
Remove NPM and only use YARN #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but what's with all the docs changes?
the |
* remove npm; use yarn * fix precommit hook and add lint-staged as a dev dep * fix precommit hook and add lint-staged as a dev dep * use node:18 as github runner * remove docs and api builder * temporarily cast expected assignments to string
* remove npm; use yarn * fix precommit hook and add lint-staged as a dev dep * fix precommit hook and add lint-staged as a dev dep * use node:18 as github runner * remove docs and api builder * temporarily cast expected assignments to string
* remove npm; use yarn * fix precommit hook and add lint-staged as a dev dep * fix precommit hook and add lint-staged as a dev dep * use node:18 as github runner * remove docs and api builder * temporarily cast expected assignments to string
* remove npm; use yarn * fix precommit hook and add lint-staged as a dev dep * fix precommit hook and add lint-staged as a dev dep * use node:18 as github runner * remove docs and api builder * temporarily cast expected assignments to string
labels: mergeable
Fixes: #issue
Motivation and Context
Noticed that both
yarn.lock
andpackage-lock.json
files are present; yarn looked more broadly used so I decided to stick to it.Description
npm
pre-commit
executablelint-staged
dev packageHow has this been tested?