Skip to content

Remove NPM and only use YARN #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Remove NPM and only use YARN #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a23e47
remove npm; use yarn
leoromanovsky Aug 29, 2023
3f0108e
fix precommit hook and add lint-staged as a dev dep
leoromanovsky Aug 29, 2023
caa5f0f
fix precommit hook and add lint-staged as a dev dep
leoromanovsky Aug 29, 2023
d5e1bd6
use node:18 as github runner
leoromanovsky Aug 29, 2023
1652dbe
remove docs and api builder
leoromanovsky Aug 29, 2023
a433095
temporarily cast expected assignments to string
leoromanovsky Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint-test-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: '14.x'
node-version: '18.x'
- uses: actions/cache@v2
with:
path: './node_modules'
Expand All @@ -35,7 +35,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: '14.x'
node-version: '18.x'
- uses: actions/cache@v2
with:
path: './node_modules'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 12
- run: npm install
- run: npm test
- run: yarn install
- run: yarn test
- uses: JS-DevTools/npm-publish@v1
with:
token: ${{ secrets.NPM_TOKEN }}
Expand Down
1 change: 0 additions & 1 deletion .husky/.gitignore
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions .husky/pre-commit
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,12 @@ testDataDir := test/data/
test-data:
rm -rf $(testDataDir)
mkdir -p $(testDataDir)
gsutil cp gs://sdk-test-data/rac-experiments-v2.json $(testDataDir)
gsutil cp gs://sdk-test-data/rac-experiments-v3.json $(testDataDir)
gsutil cp -r gs://sdk-test-data/assignment-v2 $(testDataDir)

## prepare
.PHONY: prepare
prepare: test-data
husky install
rm -rf dist/
tsc
webpack
api-extractor run --local
Loading