Skip to content

ForeverFlip 2.1.0-beta.1

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 13 Nov 15:35
· 73 commits to main since this release

Warning

Beta for testing. What to check in game:
the current checklist,
how to report: Beta testing.

A full code review (160 findings) and its fixes. Deposits are estimated one way everywhere, and
merchant sales and purchases are booked only once the bags show them.

Fixed

  • Best sale advice compares vendor proceeds with observed auction prices, before raising a post
    to the player's minimum. The tooltip shows those market proceeds separately from the protected
    posting suggestion. Merchant candidates no longer depend on auction-house sellability and
    consistently respect hidden, kept and locked items.
  • Selling explanations use the existing three-line scroll area above the price controls, keeping
    long warnings readable without overlapping inputs.
  • Journal filters preserve purchase kind through merging and reconstruction; won bids mark the
    correct lot, and vendor, resale and bid purchases of the same item remain separate.
  • Code review fixes (2.0.0-beta.1 and Unreleased code).
    • Accounting: the one-time journal recount no longer rebuilds stock, lifetime statistics, lots
      and daily totals from the 500-entry journal (it wiped stock bought before the journal window),
      and only invoice purchases of the player's own posts become returns. Open purchase lots are
      never dropped by the 300-lot cap. A late purchase is booked only on one money change equal to its
      price, and no longer wipes a purchase under way. A buyout's own You won line no longer closes a
      running bid; an unknown purchase is settled by its line or mail and cannot be booked twice.
      Listings and purchase mail are matched for the 31-day life of auction mail, so late mail no
      longer books a sale, purchase or deposit twice. A cancel's loss is booked once the next list of
      own auctions confirms it, once per auction. Sell all and Vendor sold book only the units of the
      position, sell only vendor-deal units, and the anti-undercut "to a vendor" mark expires and is
      cleared when the item leaves. Post next bought posts only unlisted bought units and keeps the
      keep rule. Losses without stock reach the daily totals and the 7-day summary uses them too.
    • Buying: Confirm never buys an item that is no longer selected or ignored, and Buy all to vendor
      confirms only its own quote. The visit spending limit applies to every purchase path, bids and
      buyouts included, and a limit below 1 gold is kept. Bids wait for a fresh search, never go
      against the player's own lead or an alt's auction, and a bid the server never took is not shown
      as leading.
    • Searches: checks started by hovering or by the buy run wait for a full scan's answer; the "only
      yours" shortcut needs the player's own lot; a stuck throttle's allowance is no longer spent by
      checks that send nothing; dropped sniper and gear messages are released; pages of filtered rows
      are read on; Stop ends the buy run and own-auction checks. Price checks are kept per auction
      house, and prices of lots the player just bought are no longer undercut.
    • Full scans: a house that shrank is scanned again, unanswered requests back off, a resumed answer
      is read, another addon's scan no longer blocks checks for ten minutes, rows read late keep scan
      order, closing while a scan finishes books it once, other characters' purchases no longer hide
      sales, and the player's own uploaded scans are not merged back as community data.
    • Sharing: transfers expire on inactivity, pace within the client's allowance and retry throttled
      parts, one copy is sent at a time, 'Scan sent.' means a scan was sent, and peers' cheapest
      prices, sales, keys, scopes and announcements are checked.
    • Interface: tables sort item links by name and scroll past the first rows (Undercuts), footers
      count every row, a waiting key capture ends with its page, settings keep fractions and decimal
      commas, merchant items come back after closing on the ForeverFlip tab, the hidden window is no
      longer redrawn after the auction house closes, and several texts (cut, ages, run status) are
      right and translated.
    • Speed: break-even is computed in a few steps, the sniper judges rows within a time budget, browse
      keys are learned once per row, raw scan lines are read once and joined in slices, and bid
      candidates, Sure values and Undercuts plans are no longer recomputed needlessly.
    • Merchant: Gear I can't use no longer prints a sale before anything sold (the chat tells what
      really sold at the end), both gear buttons wait while a merchant sale goes, and Stop ends a
      merchant sale through the sale itself, settling stacks queued to be sent again.
    • Deposits: one model for every estimate (Market.postDeposit). Advice, deals, the sniper,
      merchant offers, crafting, bids, posts, cancels and the anti-undercut plan all count the game's
      deposit when known, else 15% of the vendor price for the duration posts go for, at least
      1 silver per auction, with one deposit per commodity stack. Cheap commodity resales are sniped
      and offered at merchants again, and the anti-undercut plan's cancel and repost cost what the
      cancel and the post really book. Under Auto every estimate uses the item's own duration, the
      one its post would go for, not always 24 hours.
    • Merchant purchases are booked as their units reach the bags: units a merchant refused (no
      room, sold out) no longer enter stock or the journal. Sales and purchases at a merchant share
      one watch (Merchant.track): booked when the bags show them, given up after their wait, and
      sales end when the merchant closes while purchases keep waiting for their units.

Changed

  • Journal and profit has views of its own: All, Resale, To vendor, Bids. A third menu level
    under the entry, in the auction house's own look for it (One-Handed Axes under One-Handed), shows
    the purchases of one way of dealing. Purchases won with a bid are marked so.
  • Vendor deals use all the money in the bags. A merchant pays at once, so a vendor deal is no
    longer held to the share kept for resales (spendShare). When the money no longer covers a deal
    (other purchases since the scan), it shrinks to the units the money buys, cheapest first,
    instead of standing at "not enough money".
  • Journal: Sold and Profit columns are wider ("4878/5148", "4878 in stock" fit), the name
    column gives up the room.
  • Cancels made with ForeverFlip are logged in the journal (kind "cancel", the deposit and fee
    lost), so a recount keeps them.
  • Analytics, By item. The name column is narrower, the others wider with full names (Bought,
    Sold, In stock, Profit, Days to sell, Posts sold), and each header explains its column when
    hovered. Table headers can carry such a tooltip.
  • Purchases of one item close together are one lot. Buys of the same item within 15 minutes
    of its last lot (one position bought in several clicks, or bought back from your own posts) join
    that lot in the journal table; lots saved before are joined once.
  • Analytics overview layout. The results on the left with Earned most, Lost most and What to
    do as labels beside their text; the chart's title and the 7/30 days buttons on one row, the
    chart under them over the full height (its zero line splits gains and losses), a rule above the
    tabs.

Fixed

  • Cancelled auctions were booked as purchases. WoW Forever mails a cancelled auction's items
    with a buyer invoice; it was booked as a purchase at the post's price (in one game: 35 gold of
    Fish Bowls and Enchanted Lutes never bought). A buyer invoice from yourself, or with a cancelled
    or expired subject, is now a post that came back. Once per character the journal is recounted:
    such returns (buys of one item booked within 10 seconds of each other while mail was taken, of
    an item the player had posted at that price) become returns, and the stock, costs, profits,
    purchase lots and daily totals are corrected by them; nothing the journal no longer holds is lost.
  • Lost is calculated. Posts that came back without a known deposit (expired before deposits
    were booked, the returns above) get the deposit worked out from the merchant price, the quantity
    and the duration in the settings.
  • An item without a sale seen was sent to a merchant. No sale over the hours it was watched
    counted as a chance of zero: 20 lost deposits were charged against its post (a 28-silver glove:
    -17 silver at the auction house, so the merchant's 3 silver won). It now counts as half a sale
    over the time watched: a short watch leaves a fair chance, months without a sale nearly none.
  • Analytics overview text ran into the tabs. The left column is wider, Earned most, Lost most
    and What to do share one label column and wrap under their own text, at most two lines each.
  • The journal table's scroll bar jumped back to the top. The rows were windowed twice; the
    table also shows 16 rows now, filling its block.
  • Checks of auctions only you sell stalled. WoW Forever never answers a search of an item no
    other player sells: each such check waited out its time, forgot the item's versions (the next
    check browsed again) and was sent once more at the end. A search with no answer of an item the
    last full scan (up to 2 hours old) saw no other seller of is now answered as "only yours" at
    once, without a retry, and keeps its versions.

Added

  • Journal and profit is a table of purchases. Each purchase is a row: when, what, units sold of
    units bought, the price paid each and in all, what its posts lost (deposits of expired and
    cancelled posts and cancel fees), what its sold units brought after the cut, and the profit
    once all of it is sold (else how many are still in stock). Sales take the oldest purchase first.
    Earlier trades are filled in from the journal.
  • Selling keeps a minimum profit over the real cost. Deposits lost on reposts and cancel fees
    join the stock's cost, and no post goes below that cost plus Selling, % over cost (Settings,
    5% by default). The floor holds for Post, Post all, Post next bought and Undercuts. The tooltip's
    "You hold" shows what reposts lost.

Fixed

  • A part of the scan was read as a smaller house (185 980 of 283 783 auctions stopped for a
    minute and was taken). A list under 75% of the last complete scan of the last 3 hours is a part
    and is never read; after a longer break, a list under half of the day's largest is. A house that
    really shrinks does so a little between two scans.

  • Formula audit. An outside review of every formula found real defects; all that change a
    decision are fixed:

    • Sale chances of a large number read 100% instead of almost 0: the first term of the
      negative binomial rounded to zero and every term after it too. Terms are now kept as logs.
    • Undercuts counted the deposit already paid twice against every option that cancels: waiting
      gets it back with a sale, so cancelling now costs only the game's extra cancel fee. A merchant
      can now beat waiting when it should.
    • A first bid ignored the minimum return (a bid of 99 for a worth of 100 passed); every bid now
      keeps both the minimum profit and the minimum return.
    • Shop materials bought a day of the product's units in crafts: a recipe making 5 bought
      5 times too many.
    • Another seller's smaller lot read as a partial purchase: lots now match only within one
      known seller.
    • Sure rose with purchases at other prices: the real-buyer share now uses the sales at the
      price only.
    • Sweeps compared counts of pairs of different lengths, and never faded: a 3-hour pair at the
      usual rate was cut as a sweep, and old sweeps kept Sure at half for good. Rates per hour are
      compared, and the counts decay.
    • Deposits lost before a sale were capped at four posts: an item that sells on 5% of posts
      loses 19 deposits, not 4. Expected expired posts are now (1 − s) / s, up to 20.
    • Analytics lost sales past the 500-entry journal: daily totals (60 days) feed it now.
    • A price cap was passed when nobody had a normal price; the cap now holds. Break-even is the
      lowest price that returns the cost (it could be one step higher). A price above every measured
      level no longer borrows sales from below it. Undercuts counts your own lots ahead for each price
      an option posts at.
  • Full scans stopped for hours. The server answered ever more slowly (2, then 4, then over
    5 minutes); the scan gave up at 5 minutes and called again while the server still worked on the
    last call, and in game no scan came for seven hours. It now waits up to 10 minutes, and each call
    left unanswered in a row adds 5 minutes before the next (up to 30); an answer resets it.

  • Undercuts text showed one line. A text that does not wrap shows only its first line in game;
    each row of the block now has its own line, so the block is filled.