Skip to content

ForeverFlip 2.2.0-beta.1

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 14 Nov 18:49
· 58 commits to main since this release

Warning

Beta for testing. What to check in game:
the current checklist,
how to report: Beta testing.

A vendor deal is no longer offered on an item no merchant buys, Check all during a full scan no
longer throws the scan away, and Selling → My items says why a route pays more.

Added

  • The Crafting page can hide recipes you have not learned. The game lists every recipe of a
    profession, learned or not, so recipes you cannot craft yet stood in the profit table with a
    profit you could not take. A button above the footer switches between Learned recipes only
    and All recipes, the count says how many are hidden, and an unlearned recipe shown in the
    full list is greyed with (not learned). Off by default.
  • Check all works on the Journal pages. It reads the current price of every item the page
    shows (Resale, To vendor and Bids read their own purchases), so the figures behind the rows can
    be brought up to date without leaving the page.
  • The Best column of My items explains itself. Hovering it shows both routes for one unit side
    by side — what a vendor pays (marked * until a merchant has been seen to pay it), what the
    auction house brings after its cut, and the deposits a lot is expected to lose — with the
    difference and which way it goes. Until now the column said Vendor or AH and left the
    arithmetic to the player.
  • The My items footer has been rebuilt. Three fixed lines and the price controls underneath sat
    in a 108-pixel block, so a long explanation (the sale route, the market, the minimum) ran into the
    fields. It now has the Undercuts page's shape: seven scrolling lines on top, then the price,
    quantity and duration, then the posting buttons, in a 146-pixel block.
  • /ff refused shows, and can forget, the session's merchant refusals. A sale the server was
    too busy to take can look exactly like a merchant refusing the item, and the verdict lasted the
    session. The command names what has been learned and clear forgets it.

Fixed

  • Check all no longer ends the full scan. The button read Stop whenever any work ran, and a
    full scan counts as work: pressing Check all during the five to ten minutes of a scan
    cancelled the scan the player was waiting for, and the checks that were wanted never ran. The
    button keeps its own name during a scan (the checks wait for it and start when it settles) and
    reads Stop only while checks, a sale or a purchase run, which is what it actually ends. A
    running scan is stopped from its own button, which reads Stop scan while it runs. A Check all
    whose searches the scan holds back is no longer counted as unanswered either, so the chat no
    longer says "no answer for: ..." about searches that were never sent.
  • The gear button no longer runs off the merchant window. Sell gear I can't use is 30 letters
    in Ukrainian against a 180-pixel button anchored to the frame's right edge, and the game lets a
    button's text spill past it, so the label left the window. Buttons now widen to fit their label,
    whichever language it is in.
  • A vendor deal on an item merchants do not buy. Item data gives a sell price for some items a
    merchant refuses — a rogue's poisons are the ones seen — so they were listed under To vendor
    as certain profit and could not be sold. There is no client call that says a merchant will refuse
    an item before the sale, so the refusal is learned: a stack the merchant does not take (three
    tries over ten seconds, with the merchant still open and the stack still in the bags) is
    remembered for the session, and from then on the item is left off Sell to vendor and no scan
    or price check brings its vendor deal back to the list. The Merchant tab adds a line when items in
    the bags are left out for this reason, so their absence is explained rather than silent. An item
    the game itself flags as having no value (hasNoValue in the container info) is left out at once.
    A wrong verdict — a sale the server was too busy to take — would keep a good item off both lists
    until the next reload, so /ff refused lists what has been learned this session and
    /ff refused clear forgets it.
  • The auction house is no longer named twice. The game's title bar read "ForeverFlip: Alliance
    AH" while the addon's own bottom bar already names the open house; the title is just ForeverFlip.
  • The learned professions list no longer runs off the window. It was one text under the
    Crafting table: with more than a few professions the last lines were past the bottom edge and
    could not be reached. It scrolls now, like the other text blocks, and the whole list is readable.
  • A vendor offer is listed whatever it costs. A To vendor row was only listed if the money
    in the bags paid for all of it, so an offer worth more than the purse simply vanished. Vendor
    deals are paid at once and carry no risk, so the offer is now shown in full — Qty and Cost are
    the whole lot on the shelf — and Buy takes the part the money covers, the Status column saying
    cannot afford it yet while it covers none. The offered units were also thrown away when the
    purse could not pay, so the deal could not come back when the money did; it does now.
  • The To vendor table shows what it is about. Its columns are Name, Qty, Buy at, Sells at,
    Cost, Profit and Status: Cost is the money the whole lot asks for (Qty × Buy at), which was not
    shown anywhere, and Est./day and Sure are gone (a merchant pays at once, so there is nothing to
    wait for and nothing to estimate).
  • A purchase sold before its own mail arrived was counted twice. Buying, selling, reading the
    sale's mail and only then looting the purchase's own mail (the sale's invoice is the one that
    arrives first) booked the purchase a second time: an extra row in the journal, a stock figure
    with units that were never paid for, and a purchase lot left open for good. The sale now settles
    the waiting purchase, so the later mail is matched rather than booked.
  • A "wait" advice is no longer a dead end. When keeping an auction paid best, Answer next
    showed (0) and stayed grey — it counted only auctions whose advice is an action. The other way
    out buttons did work, but a list of undercuts beside a disabled button reads as broken. The panel
    now says in words why Answer next leaves that one alone.
  • A running buy out is marked instead of holding the page. While a buy out from Answer next
    runs, its row says buy out running in the Advice column and is no longer counted as an undercut
    to answer, so a finished decision stops standing in the list as if it were still open.

Development

  • The tests run in parallel. python tools/devflow.py test runs one process per module, about
    a minute in twenty seconds, and test <word> narrows the run to a module or a test name.
  • pyflakes is part of the check. The pre-commit hook and CI report unused imports and
    undefined names in the tests, the Sync helper and the tools.
  • CI checks Windows too, where the local flow, the hooks and the Sync helper actually run.
  • The Lua diagnostics see the game. undefined-global is on again: the names the game's
    interface gives the addon live in references/wow-forever-globals.lua, so a misspelt call is
    reported and a wrong one is not.