-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Updating next branch with changes to master since 2.4.1 and patch releases #2390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update master branch with v241 changes
add action to create samples.zip and attach to Release
Notebook Docker: use conda-forge/pypi
Update guide - add_model_using_model_extension.ipynb
Resolved `ItemPropertie` typo in Validate user profiles sample
Fix typo and add ItemProperties link
update release notes for 241 patch
add various updates and images for samples to align with MapContent
Update references of WebMap to Map and WebScene to Scene
Update urls in hyperlinks and change format of references to other api doc to be relative
fixed link for web scene specification
[Notebooks PR] Update coastline_classification_using_feature_classifier.ipynb
rewording to reflect order of release
update to knowledge graph guides for new classes
Updated username syntax in `Working with different authentication schemes` guide for for Portal-tier authentication with Active Directory
add deprecation notice for 2.4.1
network analysis guide 5 - updating data and mapping functions
network analysis guide4 - updated data and mapping
updates to network analysis guide 3 service areas
update phrasing in llm 3rd party guide
Integrate Grad-CAM into the existing notebook
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Create samples.zip | ||
run: | | ||
zip -r samples.zip samples | ||
- name: Upload samples.zip to release | ||
uses: softprops/action-gh-release@v2 | ||
with: | ||
files: | | ||
samples.zip |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To address the problem, you should add a permissions
block to the workflow to explicitly specify the minimum necessary permissions. Since the workflow uploads a file to a release, it requires contents: write
for that operation. The most logical placement for the block is at the job level (under upload-samples:
), because that's where runs-on and steps are defined, and it allows future jobs to specify different permissions as needed. Add the following to the job's block:
permissions:
contents: write
No additional methods, packages, or imports are needed. Only a YAML edit is required.
-
Copy modified lines R14-R15
@@ -11,6 +11,8 @@ | ||
|
||
jobs: | ||
upload-samples: | ||
permissions: | ||
contents: write | ||
runs-on: ubuntu-latest | ||
|
||
steps: |
No description provided.