Skip to content

Conversation

jyaistMap
Copy link
Collaborator

No description provided.

mbana641 and others added 30 commits January 6, 2025 06:38
Update master branch with v241 changes
add action to create samples.zip and attach to Release
Notebook Docker: use conda-forge/pypi
Update guide - add_model_using_model_extension.ipynb
Resolved `ItemPropertie` typo in Validate user profiles sample
Fix typo and add ItemProperties link
update release notes for 241 patch
jyaistMap and others added 26 commits September 16, 2025 14:17
add various updates and images for samples to align with MapContent
Update references of WebMap to Map and WebScene to Scene
Update urls in hyperlinks and change format of references to other api doc to be relative
[Notebooks PR] Update coastline_classification_using_feature_classifier.ipynb
update to knowledge graph guides for new classes
Updated username syntax in `Working with different authentication schemes` guide for for Portal-tier authentication with Active Directory
add deprecation notice for 2.4.1
network analysis guide 5 - updating data and mapping functions
network analysis guide4 - updated data and mapping
updates to network analysis guide 3 service areas
update phrasing in llm 3rd party guide
Integrate Grad-CAM into the existing notebook
@jyaistMap jyaistMap requested a review from jtroe October 11, 2025 19:26
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment on lines +14 to +26
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4
- name: Create samples.zip
run: |
zip -r samples.zip samples
- name: Upload samples.zip to release
uses: softprops/action-gh-release@v2
with:
files: |
samples.zip

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 3 days ago

To address the problem, you should add a permissions block to the workflow to explicitly specify the minimum necessary permissions. Since the workflow uploads a file to a release, it requires contents: write for that operation. The most logical placement for the block is at the job level (under upload-samples:), because that's where runs-on and steps are defined, and it allows future jobs to specify different permissions as needed. Add the following to the job's block:

permissions:
  contents: write

No additional methods, packages, or imports are needed. Only a YAML edit is required.


Suggested changeset 1
.github/workflows/release-create-samples-zip.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/release-create-samples-zip.yaml b/.github/workflows/release-create-samples-zip.yaml
--- a/.github/workflows/release-create-samples-zip.yaml
+++ b/.github/workflows/release-create-samples-zip.yaml
@@ -11,6 +11,8 @@
 
 jobs:
   upload-samples:
+    permissions:
+      contents: write
     runs-on: ubuntu-latest
 
     steps:
EOF
@@ -11,6 +11,8 @@

jobs:
upload-samples:
permissions:
contents: write
runs-on: ubuntu-latest

steps:
Copilot is powered by AI and may make mistakes. Always verify output.
@jyaistMap jyaistMap merged commit 8da2ec5 into next Oct 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.