-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add queryFeatures() to send query requests to feature services #126
Conversation
since it was originially PR'd before 1.0.3 release
this looks awesome. how is paging normally handled for developers using services like this? is it worth having a convenience method like |
@apfister you should open an issue for that. @jgravois also suggested adding it and pointed me to https://github.com/koopjs/featureservice/. We'd have to figure out the relationship between that lib and arcgis-rest-feature-service. One idea would be to make a PR over there to use arcgis-rest-feature-service, which should solve the issue about it not working in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I saw a few minor typos. Also, it might be good to have some example tree types and conditions in the demo, either in the placeholder or somewhere else. Just to make it a little more clear
<div class="col-md-12"> | ||
<div class="jumbotron" > | ||
<h1>search features!</h1> | ||
<form id="searchFrom" class="form-inline"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be searchForm
?
<script src="node_modules/@esri/arcgis-rest-feature-service/dist/umd/arcgis-rest-feature-service.umd.js"></script> | ||
|
||
<script> | ||
// respond when s user fills out he search text and hits enter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos here
Thanks @noahmulfinger, I'll address your comments when I update this for #129. |
@jgravois the noodling began back in 2013! let's put those noodles in the pot! ok, i'll see myself out now.. |
want to make sure query features demo works when other packages are configured as externals and excluded from the UMD bundle
now that it is treated as external and not included in the bundle
more like a query and less like search
@apfister QueryToCsv for life yo! |
@jgravois FYI - I have this working via Let me know what I can do to help cut a release so I can show that live on Tues. |
Will do later this evening |
resolves #116