-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore some video capabilities by restoring quicktimevideo.cpp
#2337
Conversation
This pull request fixes 1 alert when merging 1d6be12 into 89d7798 - view on LGTM.com fixed alerts:
|
94306d2
to
1b87806
Compare
This pull request fixes 1 alert when merging 1b87806 into 89d7798 - view on LGTM.com fixed alerts:
|
1b87806
to
ce987ae
Compare
Codecov Report
@@ Coverage Diff @@
## main #2337 +/- ##
==========================================
- Coverage 63.47% 63.16% -0.31%
==========================================
Files 118 119 +1
Lines 19584 20433 +849
Branches 9569 10164 +595
==========================================
+ Hits 12431 12907 +476
- Misses 5088 5403 +315
- Partials 2065 2123 +58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
00afe0a
to
3cdfdfe
Compare
3cdfdfe
to
de5a289
Compare
This pull request fixes 1 alert when merging de5a289 into 89d7798 - view on LGTM.com fixed alerts:
|
Thanks @piponazo! I don't have a windows dev env, but let me first try to play a round of trial and error ci ping pong 😂 |
I would try replacing |
This is great! Thank you so much! FYI, because you said "partially close #1748" in the PR description it will close that issue when this PR is merged, which doesn't seem like what you intended Hopefully @notorand-it can give you a quick okay to use the test file, but if you don't hear back or it's holding things up, I should be able to create a small test video in that case. |
c694e1d
to
e97855b
Compare
This pull request fixes 1 alert when merging e97855b into 71dc04e - view on LGTM.com fixed alerts:
|
e97855b
to
56e9762
Compare
56e9762
to
b04e48c
Compare
Added a test file that I created myself, so once the ci is green this is good to go form my side :) |
This pull request fixes 1 alert when merging b04e48c into 71dc04e - view on LGTM.com fixed alerts:
|
quicktime.{h,cpp}
files and adapt them to work with the current version of exiv2Add https://github.com/HowardHinnant/date as dependency to have sane handling of dates in c++ (I picked this library because it will be standard in c++20)Add some xmp printer conversions such that e.g.TrackCreateDate
isn't just printed as seconds since 1904...Before we can merge this I'd need an ok from @notorand-it to add his file to this repo for testing purposes. Could you adapt your issue #2237 to include that you license the original file as CC0?Test file is created by myself and I hereby license it under CC0
This would close #2237 (fyi @benmccann), and partially close #1748.
EDIT: date library and pretty printers removed again... I couldn't really figure out how to fix the ci and don't really have the time to go debug these ci issues.