feat: generate open classes for types with field arguments #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danadajian
force-pushed
the
default-to-open-class
branch
from
809c314 to
6e44e9e
Compare
# Conflicts: # test/unit/should_generate_field_resolver_interfaces/expected.kt # test/unit/should_honor_resolverTypes_config/expected.kt
danadajian
force-pushed
the
default-to-open-class
branch
2 times, most recently
from
5f278ab to
dc4d984
Compare
danadajian
force-pushed
the
default-to-open-class
branch
from
dc4d984 to
3f0459d
Compare
danadajian
force-pushed
the
default-to-open-class
branch
from
d1b1e2d to
265ffce
Compare
danadajian
changed the title
danadajian
changed the title
danadajian
force-pushed
the
default-to-open-class
branch
from
5675bf9 to
2f683a2
Compare
danadajian
changed the title
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
danadajian
added a commit
that referenced
this pull request
Apr 30, 2024
BREAKING CHANGE: Generate open class rather than interface for types with field arguments BREAKING CHANGE: Remove extraResolverArguments config, which is redundant following #52 BREAKING CHANGE: Rename resolverTypes config to resolverClasses and change its schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
BREAKING CHANGES:
resolverTypesconfig toresolverClassesand change its schemaAlso documented recommended usage of the
resolverClassesconfig.🔗 Related Issues