bgpd: Do not use mapped IPv4/IPv6 addresses for unnumbered peering #16582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
```
router bgp 4283023031
bgp router-id 100.83.23.31
neighbor leafs peer-group
neighbor leafs remote-as external
neighbor eth1 interface peer-group leafs
!
address-family ipv4 unicast
network 100.83.23.31/32
exit-address-family
!
exit
```
```
leaf2# show ip bgp 100.83.23.31/32
…
4283023031
::ffff:6453:171f (inaccessible) from node31-h23-osl3(swp32) (100.83.23.31)
(fe80::a6bf:1ff:fe2d:689a) (used)
Origin IGP, metric 0, invalid, external
Last update: Tue Aug 13 08:36:46 2024
```
Fixes: fc5a738 ("bgpd: set ipv4-mapped ipv6 for ipv4 with ipv6 nexthop")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
More makes sense to back these changes out at all for now, related: #16587. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #16572