Merge (Cell|Face)(Scalar|Vector)Values #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/merge-values
branch
3 times, most recently
from
93b6ab4
to
7b05cfc
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 92.63% 92.65% +0.01%
==========================================
Files 30 30
Lines 4429 4355 -74
==========================================
- Hits 4103 4035 -68
+ Misses 326 320 -6
☔ View full report in Codecov by Sentry. |
fredrikekre
commented
May 15, 2023
termi-official
requested changes
May 15, 2023
fredrikekre
force-pushed
the
fe/merge-values
branch
from
80b39a2
to
32ca781
Compare
…)Values` This patch merges: - `CellScalarValues` and `CellVectorValues` into `CellValues`, - `FaceScalarValues` and `FaceVectorValues` into `FaceValues`, - `PointScalarValues` and `PointVectorValues` into `PointValues`. This is possible now that interpolations are vectorized instead (#694) and, for example, `CellVectorValues(::Interpolation)` can now be spelled as simply `CellValues(::VectorInterpolation)`. The new structs have new parametrization to be more general wrt the storage types to enable embedded elements (#651). They are also parametrized wrt the function interpolation, to enable dispatching on this in e.g. `reinit!`. Instead of simply deprecating the old API (with a warning) this patch implements hard errors for the old constructors with a clear message on how to upgrade. The reason for this is that i) it is possible to tank performance with the new parametrization, ii) for any non-trivial use one would run into errors anyway (e.g. `f(::CellVectorValues)` would give a non-descriptive `MethodError`). Closes #682.
fredrikekre
force-pushed
the
fe/merge-values
branch
from
32ca781
to
98f9b15
Compare
termi-official
approved these changes
May 16, 2023
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.