fix: ignore error when key not found in keys delete #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
- Coverage 70.41% 70.41% -0.01%
==========================================
Files 643 643
Lines 54758 54759 +1
==========================================
Hits 38560 38560
- Misses 14023 14024 +1
Partials 2175 2175
|
170210
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
Signed-off-by: 170210 <j170210@icloud.com>
jaeseung-bae
approved these changes
Mar 27, 2024
ulbqb
approved these changes
Mar 27, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* fix(client/keys): don't return when key not found in keys delete (#18562) * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com> (cherry picked from commit e5709f3) # Conflicts: # CHANGELOG.md
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
…1315) * fix: ignore error when key not found in keys delete (#1312) * fix(client/keys): don't return when key not found in keys delete (#18562) * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com> (cherry picked from commit e5709f3) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: 170210 <85928898+170210@users.noreply.github.com> Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.
This pr cherry-pick the following pr:
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml