-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore error when key not found in keys delete (backport #1312) #1315
Conversation
* fix(client/keys): don't return when key not found in keys delete (#18562) * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com> (cherry picked from commit e5709f3) # Conflicts: # CHANGELOG.md
Cherry-pick of e5709f3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.48.x #1315 +/- ##
================================================
Coverage 69.78% 69.78%
================================================
Files 646 646
Lines 67541 67541
================================================
Hits 47134 47134
Misses 18218 18218
Partials 2189 2189 |
Description
If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.
This pr cherry-pick the following pr:
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
This is an automatic backport of pull request #1312 done by [Mergify](https://mergify.com).