Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore error when key not found in keys delete (backport #1312) #1315

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 27, 2024

Description

If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.

This pr cherry-pick the following pr:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1312 done by [Mergify](https://mergify.com).

* fix(client/keys): don't return when key not found in keys delete  (#18562)

* chore: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com>
(cherry picked from commit e5709f3)

# Conflicts:
#	CHANGELOG.md
Copy link
Contributor Author

mergify bot commented Mar 27, 2024

Cherry-pick of e5709f3 has failed:

On branch mergify/bp/release/v0.48.x/pr-1312
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit e5709f332.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/keys/delete.go
	modified:   client/keys/delete_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from jaeseung-bae as a code owner March 27, 2024 09:33
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (506f8ff) to head (506f8ff).

❗ Current head 506f8ff differs from pull request most recent head 8ffc905. Consider uploading reports for the commit 8ffc905 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.48.x    #1315   +/-   ##
================================================
  Coverage            69.78%   69.78%           
================================================
  Files                  646      646           
  Lines                67541    67541           
================================================
  Hits                 47134    47134           
  Misses               18218    18218           
  Partials              2189     2189           

@0Tech 0Tech self-assigned this Mar 29, 2024
@0Tech 0Tech added A: bug Something isn't working C:client and removed conflicts labels Mar 29, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit 0c0e2c2 into release/v0.48.x Mar 29, 2024
24 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v0.48.x/pr-1312 branch March 29, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants