You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix build break that manifests when one uses flow.cfg with custom validator expressions (as passed to FLOW_CFG_OPTION_SET_DECLARE_OPTION*()).
This was a regression from v2.0.0 to v3.0.0.
flow::cfg::Config_manager: Eliminate harmless compiler warnings (seen with at least some clang versions) when one uses this class template.
flow::cfg::Option_set: Avoid an assertion failure inside Boost.Program_options that appears when parsing or pretty-printing option values.
The problem appeared only with Boost libraries built in debug mode.
Bug fix: flow::cfg::Option_set::reject_candidate() did not discard the changes accumulated in values_candidate(), so that a subsequent parse_*() (if any) would build on top of the rejected candidate. Now any subsequent parse starts fresh (identical values_candidate() and values() contents). The bug may have affected the use of Config_manager and Static_config_manager, though hitting it is unlikely:
Dynamic updates (Config_manager::apply_dynamic()) were not affected by this bug.
Only an initial parse could be affected: Config_manager::apply_static[_and_dynamic]() or Static_config_manager::apply(). To hit this bug:
One must first fail an initial parse (apply...()), but after at least 1 file was successfully parsed. (E.g., reject the overall parse via final-validator hook.)
The successful parts of this parse must also change at least 1 option's value relative to its default.
One must then retry the parse (apply...() again) but this time fully succeed.
This successful-retry parse must leave unspecified a value changed by the earlier failed parse.
Note: A failed initial parse is typically a fatal error, not followed by another attempt.
Minor bug fixes:
When pretty-printing option values, lists of durations are now printed in convenient units (e.g., "1 minute" instead of "60000000000 nanoseconds"), as lone durations already were.
flow::cfg::Config_manager::apply_static(), when it fails, no longer logs a message claiming the current (unchanged) state was just made canonical.
dynamic_cfg_context.hpp can now be #included by itself.