-
Notifications
You must be signed in to change notification settings - Fork 51
Closed
Description
This is because last time we tried to use OpenPGP.js in the content script, it didn't work (on Firefox). Actually, it would be nice to load it there. Then we wouldn't have to make so many calls to background_script (which we have to eventually deprecate anyway because of Google Chrome extension manifest v3. #1509)
I'll file an issue to try to attempt running openpgp.js in content script again, at which point this comment could be removed, and some things simiplified, in particular:
- background calls from content script to background page that are only done because OpenPGP.js can be removed, and instead appropriate methods (which rely on OpenPGP.js) can be called directly
- pgp_block.htm/ts that today calls into background page can instead call the content script when it needs OpenPGP.js, and those background call handlers can be moved from background page to content script
Originally posted by @tomholub in #4725 (comment)