Escape HTML in password protected message intros #3480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing lots of tests, none of which seem connected to this change in any obvious way. |
|
Okay, I reran the tests for the last commit to master (which passed when the commit was merged) and they are now failing: https://flowcrypt.semaphoreci.com/workflows/9ba160ab-2172-4a99-85ca-234edf401adc?pipeline_id=320a823f-bbcf-41db-8052-d2f11c0bbe7f So I don't believe this is related to this PR specifically. |
tomholub
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, here is what happens if I include an
<i>tag in a password protected message's unencrypted intro section:As you can see, the tag is applied and the rest of the email is italicized. Here is what happens after this PR: