Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Aug 30, 2021

This PR will remove testdata.json and move its contents to const.ts

close #3422 // if this PR closes an issue


Tests (delete all except exactly one):

  • Difficult to test (explain why)
  • Not worth testing
  • Tests will be added later (issue #...)
  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from rrrooommmaaa as a code owner August 30, 2021 08:40
@martgil martgil marked this pull request as draft August 30, 2021 08:40
@limonte limonte mentioned this pull request Aug 31, 2021
5 tasks
@martgil martgil marked this pull request as ready for review September 2, 2021 04:28
@rrrooommmaaa rrrooommmaaa merged commit bf76df5 into master Sep 3, 2021
@rrrooommmaaa rrrooommmaaa deleted the issue-3422-refactor-testdata-consts branch September 3, 2021 13:50
@tomholub tomholub added this to the 8.1.5 milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

removing testdata.json

3 participants