fix #5010
Merged
fix #5010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrooommmaaa
commented
Mar 13, 2023
rrrooommmaaa
commented
Mar 13, 2023
extension/js/common/core/buf.ts
Outdated
| return Buf.fromBase64Str(b64UrlStr.replace(/-/g, '+').replace(/_/g, '/')); | ||
| }; | ||
|
|
||
| // todo: deprecate |
There was a problem hiding this comment.
I don't like this function and suggest to remove it. As in some places we might want to simplify code and use plain Uint8Array objects, and Uint8Array.toString() returns a totally different thing. (It's also hard to find usages of this function among toString() calls on other types of objects)
I suggest to explicitly use toUtfStr method)
There was a problem hiding this comment.
This one sounds good too 👍
sosnovsky
previously approved these changes
Mar 13, 2023
|
@rrrooommmaaa is this ready for merging? |
sosnovsky
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a small fix
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):