Skip to content

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Oct 9, 2024

This PR changes the manifest version used by the Thunderbird Port from v3 to v2 due to unstable support of Thunderbird Typescript typings for Thunderbird ESR 128 and above.

close #5848

issue #5786


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner October 9, 2024 09:35
@martgil

This comment was marked as outdated.

@martgil
Copy link
Collaborator Author

martgil commented Oct 10, 2024

Hi @sosnovsky - I just added some tests from the last commit. It's ready for review again. thanks!

@martgil martgil requested a review from sosnovsky October 11, 2024 05:23
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well now, thanks!

@martgil martgil requested a review from sosnovsky October 14, 2024 10:10
@martgil
Copy link
Collaborator Author

martgil commented Oct 14, 2024

Hello @sosnovsky, may I request another review? Thank you!

@martgil martgil requested a review from sosnovsky October 15, 2024 11:15
@martgil
Copy link
Collaborator Author

martgil commented Oct 15, 2024

Hi @sosnovsky - It is now good to go. thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@sosnovsky sosnovsky merged commit a6c8f59 into master Oct 15, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5848-use-manifest-v2-for-thunderbird branch October 15, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thunderbird (master branch) complains about messageDisplayScript undefined due to possible change of manifest version

2 participants