Skip to content

Conversation

gibahjoe
Copy link
Contributor

Route generator was not being passed forward from the Route classes (ChildRoute etc) despite being implemented in ModularPage

else if (router.transition == TransitionType.defaultTransition) {
      // Helper function
      Widget widgetBuilder(BuildContext context) {
        //return disposablePage;
        return router.child!(context, router.args);
      }

      if (router.routeGenerator != null) {
        return router.routeGenerator!(widgetBuilder, this) as Route<T>;
      }
      return MaterialPageRoute<T>(
        settings: this,
        builder: widgetBuilder,
      );
    }

@jacobaraujo7 jacobaraujo7 merged commit c9dbd18 into Flutterando:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants