Skip to content

Added route generator #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Added route generator #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f8f72
Merge pull request #3 from Flutterando/master
gibahjoe Jan 9, 2021
6fa74ac
added route generator to routes
gibahjoe Jan 12, 2021
3ebb202
Merge pull request #4 from Flutterando/master
gibahjoe Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter_modular/lib/src/core/interfaces/modular_route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import '../models/modular_arguments.dart';
import 'child_module.dart';
import 'route_guard.dart';

typedef RouteBuilder<T> = MaterialPageRoute<T> Function(
typedef RouteBuilder<T> = Route<T> Function(
WidgetBuilder, RouteSettings);
typedef ModularChild = Widget Function(
BuildContext context, ModularArguments? args);
Expand Down
11 changes: 10 additions & 1 deletion flutter_modular/lib/src/core/models/child_route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ class ChildRoute extends ModularRouteImpl {
List<RouteGuard>? guards,
TransitionType transition = TransitionType.defaultTransition,
CustomTransition? customTransition,
RouteBuilder? routeGenerator,
Duration duration = const Duration(milliseconds: 300),
}) : super(routerName, routerOutlet: [], duration: duration, child: child, customTransition: customTransition, children: children, guards: guards, transition: transition);
}) : super(routerName,
routerOutlet: [],
duration: duration,
child: child,
routeGenerator: routeGenerator,
customTransition: customTransition,
children: children,
guards: guards,
transition: transition);
}
4 changes: 2 additions & 2 deletions flutter_modular/lib/src/core/models/module_route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class ModuleRoute extends ModularRouteImpl {
required ChildModule module,
List<RouteGuard>? guards,
TransitionType transition = TransitionType.defaultTransition,
CustomTransition? customTransition,
CustomTransition? customTransition, RouteBuilder? routeGenerator,
Duration duration = const Duration(milliseconds: 300),
}) : assert(!routerName.contains('/:'), 'ModuleRoute should not contain dynamic route'),
super(routerName, routerOutlet: [], duration: duration, module: module, customTransition: customTransition, guards: guards, transition: transition);
super(routerName, routerOutlet: [], duration: duration,routeGenerator: routeGenerator, module: module, customTransition: customTransition, guards: guards, transition: transition);
}
3 changes: 2 additions & 1 deletion flutter_modular/lib/src/core/models/wildcard_route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class WildcardRoute extends ModularRouteImpl {
List<RouteGuard>? guards,
TransitionType transition = TransitionType.defaultTransition,
CustomTransition? customTransition,
RouteBuilder? routeGenerator,
Duration duration = const Duration(milliseconds: 300),
}) : super('**', routerOutlet: [], duration: duration, child: child, customTransition: customTransition, children: children, guards: guards, transition: transition);
}) : super('**', routerOutlet: [], duration: duration, child: child,routeGenerator: routeGenerator, customTransition: customTransition, children: children, guards: guards, transition: transition);
}