Skip to content

Conversation

@mwritter
Copy link
Contributor

@mwritter mwritter commented Jul 19, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

react-syntax-highlighter no longer supports lineNumberProps but it does support inline styles with lineNumberStyle.

Fixes #1137

Type of Change

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • example/js/index.js to test fix
  1. pnpm run build-examples
  2. pnpm run start:js
  • Notice the console warning Warning: React does not recognize the 'lineNumberProps '... is no longer present

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (I have run yarn format)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mwritter mwritter added the 🐛 Bug Issues or PRs that report or fix a bug label Jul 19, 2022
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mwritter mwritter merged commit 0700486 into main Jul 19, 2022
@mwritter mwritter deleted the fix/code-pane-console-error branch July 19, 2022 20:39
@github-actions github-actions bot mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 Bug Issues or PRs that report or fix a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning in console when using CodePane

4 participants