Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa-spin-reverse #3749

Closed
wants to merge 1 commit into from
Closed

fa-spin-reverse #3749

wants to merge 1 commit into from

Conversation

KSCooke
Copy link

@KSCooke KSCooke commented Jun 20, 2014

I attempted to use fa-history and then add fa-spin to it. Seemed as if the icon would work but the spin was going in the wrong direction. So I just applied reverse to the fa-spin class animations and it seems to work correctly. The code is not without its problems as it does not seem to work in IE. Here is the code again separately from the file.

.fa-spin-reverse {
-webkit-animation: spin 2s infinite linear reverse;
-moz-animation: spin 2s infinite linear reverse;
-o-animation: spin 2s infinite linear reverse;
animation: spin 2s infinite linear reverse;
}

I attempted to use fa-history and then add fa-spin to it. Seemed as if the icon would work but the spin was going in the wrong direction. So I just applied reverse to the fa-spin class animations and it seems to work correctly. The code is not without its problems as it does not seem to work in IE. Here is the code again separately from the file.

.fa-spin-reverse { 
  -webkit-animation: spin 2s infinite linear reverse;
  -moz-animation: spin 2s infinite linear reverse;
  -o-animation: spin 2s infinite linear reverse;
  animation: spin 2s infinite linear reverse;
}
@radubr
Copy link

radubr commented Jun 21, 2014

+1

5 similar comments
@vortex9
Copy link

vortex9 commented Jun 22, 2014

+1

@victorperin
Copy link

+1

@jbthoma
Copy link

jbthoma commented Jul 23, 2014

+1

@matthew-hull
Copy link

+1

@kelvintaywl
Copy link

+1

@tagliala tagliala mentioned this pull request Sep 2, 2014
@robertotremonti
Copy link

+1

Here's the code that should work in all browsers, including IE.

.@{fa-css-prefix}-spin-reverse {
    -webkit-animation: fa-spin-reverse 2s infinite linear;
            animation: fa-spin-reverse 2s infinite linear;
}

@-webkit-keyframes fa-spin-reverse {
    0% {
        -webkit-transform: rotate(360deg);
                transform: rotate(360deg);
    }
    100% {
        -webkit-transform: rotate(1deg);
                transform: rotate(1deg);
    }
}

@keyframes fa-spin-reverse {
    0% {
        -webkit-transform: rotate(360deg);
                transform: rotate(360deg);
    }
    100% {
        -webkit-transform: rotate(1deg);
                transform: rotate(1deg);
    }
}

@JaredCubilla
Copy link

+1

@tagliala
Copy link
Member

tagliala commented Oct 5, 2014

dup of #688, please +1 that request

since this PR can't be merged, I need to close this one

@robertotremonti the problem with reverse should be mobile browsers, as per: https://developer.mozilla.org/en-US/docs/Web/CSS/animation-direction

http://jsfiddle.net/tagliala/em2ztqsz/3/
This fiddle works on IE11. Can't test IE10.
It works on iOS 8.0

Please keep discussing on the other thread on which approach we should use

@tagliala tagliala closed this Oct 5, 2014
@dammina
Copy link

dammina commented Oct 14, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.