Implementation of grouping size aggregator #3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
requested changes
Sep 16, 2025
...le/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingContinuation.java
Show resolved
Hide resolved
...m/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsCollectorCursor.java
Show resolved
Hide resolved
...om/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursor.java
Outdated
Show resolved
Hide resolved
...om/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursor.java
Outdated
Show resolved
Hide resolved
...om/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursor.java
Outdated
Show resolved
Hide resolved
...om/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursor.java
Outdated
Show resolved
Hide resolved
...a/com/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsResultsTest.java
Outdated
Show resolved
Hide resolved
...a/com/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsResultsTest.java
Outdated
Show resolved
Hide resolved
...pple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursorTest.java
Outdated
Show resolved
Hide resolved
...pple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursorTest.java
Outdated
Show resolved
Hide resolved
- Change lifecycle to allow multiple onNext calls for an instance - Add boolean marker to continuation - Static import assertThat - Supply executor to whileTrue
alecgrieser
approved these changes
Sep 19, 2025
...om/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursor.java
Outdated
Show resolved
Hide resolved
...a/com/apple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsResultsTest.java
Outdated
Show resolved
Hide resolved
...pple/foundationdb/record/provider/foundationdb/cursors/SizeStatisticsGroupingCursorTest.java
Outdated
Show resolved
Hide resolved
…ake proto boolean optional.
alecgrieser
approved these changes
Sep 30, 2025
Comment on lines
80
to
82
| // Default to false | ||
| return (statsContinuation.hasLastResultContinuation() && | ||
| statsContinuation.getLastResultContinuation()); |
There was a problem hiding this comment.
This isn't wrong, but getLastResultContinuation() should return false (not, say, null) if the field is unset, so this should be logically equivalent to:
Suggested change
| // Default to false | |
| return (statsContinuation.hasLastResultContinuation() && | |
| statsContinuation.getLastResultContinuation()); | |
| // Default to false | |
| return statsContinuation.getLastResultContinuation()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is creating a flavor of the
SizeStatisticsCollectorCursorthat can return sizes aggregated by sub-subspaces.This relies on the original implementation but had to go into a separate class as the generic type of the cursor has changed.
Eventually, the original cursor can be replaced by this one with the aggregation size being "0".
For backwards compatibility, the original class was marked as "deprecated". The original
SizeStatisticsResultswas marked as deprecated and a new (non-embedded version) of it was added.Initially, I thought that we can make a backwards-compatible change to the
SizeStatisticsCollectorCursorclass, but that proved more complicated with the changes to the result type, so I decided to go with a new implementation instead.Resolves #3576