Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using CUDA.jl #198

Merged
merged 5 commits into from
Aug 30, 2020
Merged

Using CUDA.jl #198

merged 5 commits into from
Aug 30, 2020

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Aug 29, 2020 •
edited
Loading

  • Drops CuArrays.jl and CUDAapi.jl and uses CUDA.jl instead
  • Disallows scalar operations on GPU

Closes #180

@navidcy navidcy requested a review from glwagner August 29, 2020 04:37
@navidcy navidcy added the GPU label Aug 29, 2020
@navidcy
Copy link
Member Author

navidcy commented Aug 29, 2020 •
edited
Loading

There is an issue: the CuFourierFlows.jl methods are not exported. I guess we need to have CuFourierFlows.jl inside __init()__? Do we still need @requires ...?

@glwagner, there is some discussion in CUDA.jl Docs... I don't understand which of the options we want. I tried all I think but neither worked...

@navidcy navidcy mentioned this pull request Aug 29, 2020
Merged
@navidcy navidcy merged commit 4e17c6b into master Aug 30, 2020
@navidcy navidcy deleted the UseCUDAjl branch August 30, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CuArrays.jl --> CUDA.jl?
2 participants
@navidcy @glwagner