Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance user experience with aliasing + (fix bug in getaliasedwaveumbers) #285

Merged
merged 18 commits into from
Jun 4, 2021
Merged

Enhance user experience with aliasing + (fix bug in getaliasedwaveumbers) #285

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bc3034e
adds aliased_fraction in grids + tests + update docs
navidcy Jun 1, 2021
83c79c9
better docstrings for grid structs
navidcy Jun 1, 2021
96a8beb
fix typo: Ksqr -> Krsq
navidcy Jun 1, 2021
7ea7850
better line break
navidcy Jun 1, 2021
4c1dfe7
adds another type parameter in AbstractGrid
navidcy Jun 2, 2021
2af7f61
better getaliasedwavenumbers and also dealiase() functions
navidcy Jun 2, 2021
631c8e9
fix alias type in ThreeDGrid
navidcy Jun 2, 2021
90ee651
generalizes test_aliased_fraction
navidcy Jun 2, 2021
9aeffb2
adds test for not dealiasing
navidcy Jun 2, 2021
7e3ce16
bumps version to 0.7.0
navidcy Jun 3, 2021
e67211c
dispatch on dealias more elegantly
navidcy Jun 3, 2021
3d9fc31
testing _dealias
navidcy Jun 4, 2021
4835251
simplify dealias call
navidcy Jun 4, 2021
b624d55
adds Docs/Aliasing section
navidcy Jun 4, 2021
7328242
change example sin -> cos
navidcy Jun 4, 2021
4978ded
wavenubmers -> wavenumberes
navidcy Jun 4, 2021
5c27f94
better phrasing about Orszag's 2/3 rule
navidcy Jun 4, 2021
2939929
remove debugging println()
navidcy Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ authors = ["Gregory L. Wagner <wagner.greg@gmail.com>", "Navid C. Constantinou <
description = "Tools for building fast, hackable, pseudospectral partial differential equation solvers on periodic domains."
documentation = "https://fourierflows.github.io/FourierFlowsDocumentation/stable/"
repository = "https://github.com/FourierFlows/FourierFlows.jl"
version = "0.6.19"
version = "0.7.0"

[deps]
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
Expand Down
4 changes: 3 additions & 1 deletion docs/src/gpu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ OneDimensionalGrid
├────────── size Lx: 2.0
├──── resolution nx: 16
├── grid spacing dx: 0.125
└─────────── domain: x ∈ [-1.0, 0.875]
├─────────── domain: x ∈ [-1.0, 0.875]
└─ aliased fraction: 0.3333333333333333

```

gives out a grid whose arrays are `CuArrays`. (Calling `OneDGrid(n, L)` defaults to CPU, i.e.,
Expand Down
5 changes: 3 additions & 2 deletions docs/src/grids.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ OneDimensionalGrid
├────────── size Lx: 6.283185307179586
├──── resolution nx: 64
├── grid spacing dx: 0.09817477042468103
└─────────── domain: x ∈ [-3.141592653589793, 3.0434178831651124]
```
├─────────── domain: x ∈ [-3.141592653589793, 3.0434178831651124]
└─ aliased fraction: 0.3333333333333333
```

The grid domain is, by default, constructed symmetrically around ``x = 0``, but this
can be altered using the `x0` keyword argument of `OneDGrid` constructor. The grid
Expand Down
2 changes: 1 addition & 1 deletion src/FourierFlows.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ using Base: fieldnames
using FFTW: fftfreq, rfftfreq

"Abstract supertype for grids."
abstract type AbstractGrid{T, A} end
abstract type AbstractGrid{T, A, Alias} end

"Abstract supertype for timesteppers."
abstract type AbstractTimeStepper{T} end
Expand Down
Loading