Separate 2D Navier-Stokes stochastic forcing & budgets examples #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
changed the title
navidcy
changed the title
navidcy
changed the title
|
This PR closes #90. |
BrodiePearson
approved these changes
Sep 13, 2020
| @@ -53,26 +53,27 @@ forcing_wavenumber = 14.0 # the central forcing wavenumber for a spectrum tha | |||
| forcing_bandwidth = 1.5 # the width of the forcing spectrum | |||
| ε = 0.001 # energy input rate by the forcing | |||
|
|
|||
| gr = TwoDGrid(nx, Lx) | |||
| gr = TwoDGrid(n, L) | |||
There was a problem hiding this comment.
Is this necessary? I noticed the betadecay example doesn't explicitly define the grid, so is there a reason the betaforced example does?
There was a problem hiding this comment.
Because wave numbers are needed to construct the forcing spectrum below. I know it’s not neat but I can’t think of a better way.
There was a problem hiding this comment.
Ah I see. The decay example pulls the grid from the initialized problem, but the forced example needs the grid in order to initialize the problem with that spectrum. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separates 2D Navier-Stokes forced-dissipative example into
(i) an example that plots a movie of the vorticity field + evolution of energy/entstrophy time series
(ii) an example that plots the terms of the energy and enstrophy budgets
adds some comments/clarifications in examples
@BrodiePearson could you have a quick look at this PR?
As soon as the Documentation is built, you should be able to see a preview of how the docs should look like after merging at
https://fourierflows.github.io/GeophysicalFlowsDocumentation/previews/PR108/