Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests the enstrophy budget in BarotropicQG #120

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Sep 19, 2020

No description provided.

@navidcy navidcy requested a review from glwagner September 19, 2020 22:11
@navidcy navidcy linked an issue Sep 19, 2020 that may be closed by this pull request
@navidcy
Copy link
Member Author

navidcy commented Sep 19, 2020

@glwagner, GPU test fail because of MultilayerQG. If you go through the log you'll see that BarotropicQG test passed beautifully.

@glwagner
Copy link
Member

One of the errors comes from:

Uyy = real.(ifft(-l.^2 .* fft(U)))

Might be best to unwrap this line; there's a lot going on, including the allocation of three (?) new arrays.

@navidcy
Copy link
Member Author

navidcy commented Nov 4, 2020

I'll merge this and we can deal with MultilayerQG on GPU in a different PR

@navidcy navidcy merged commit b1614da into master Nov 5, 2020
@navidcy navidcy deleted the testenstrophybudgetsBQG branch November 5, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enstrophy budget terms in BarotropicQG are not tested
2 participants