Improvements in TwoDNavierStokes #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ierFlows/GeophysicalFlows.jl into ncc/better-twodnavierstokes
navidcy
changed the title
navidcy
changed the title
|
Ready for review! 🎉 |
BrodiePearson
approved these changes
Dec 30, 2020
| end | ||
|
|
||
| function test_twodnavierstokes_energyenstrophy(dev::Device=CPU()) | ||
| nx, Lx = 128, 2π | ||
| ny, Ly = 128, 3π | ||
| ny, Ly = 126, 3π |
There was a problem hiding this comment.
I had not noticed there was a test using an anisotropic domain and grid spacing, particularly since all of the examples use nx=ny and dx=dy. Are anisotropic grids supported across all the modules?
There was a problem hiding this comment.
Also, your compression of the dissipation function looks good to me!
There was a problem hiding this comment.
I had not noticed there was a test using an anisotropic domain and grid spacing, particularly since all of the examples use nx=ny and dx=dy. Are anisotropic grids supported across all the modules?
Yes!
liasiegelman
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@docsrefs in the Docs/TwoDNavierStokes module pageenergy_dissipationandenergy_dragand also the corresponding diagnostics forenstrophyThis PR introduces breaking changed and should come with the minor release.