Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs #221

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Fix some bugs #221

merged 5 commits into from
Apr 6, 2021

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Apr 6, 2021 •
edited
Loading

This PR fixes some bugs that came up with the way CUDA.@allowscalar is called: seems like if you are creating an array you need to call CUDA.@allowscalar after the = sign.

@navidcy navidcy added the 🐞 bug Something isn't working label Apr 6, 2021
@navidcy navidcy self-assigned this Apr 6, 2021
@navidcy
Copy link
Member Author

navidcy commented Apr 6, 2021

I'll merge as soon as tests pass since #219 relies on this.

@navidcy navidcy requested a review from glwagner April 6, 2021 02:27
@navidcy navidcy merged commit 93d0a15 into master Apr 6, 2021
@navidcy navidcy deleted the ncc/fix-some-bugs branch April 6, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner Awaiting requested review from glwagner

Assignees

@navidcy navidcy

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@navidcy