Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some typos + fixes in Contirbutor's Guide #224

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Some typos + fixes in Contirbutor's Guide #224

merged 2 commits into from
Apr 12, 2021

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Apr 12, 2021

No description provided.

BrodiePearson
BrodiePearson approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@BrodiePearson BrodiePearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. There were a couple of typos elsewhere in the Contributor's Guide too:

  • Line 15: your favorite setup
  • Line 104: All PRs that introduce new features or new modules should be accompanied with appropriate...

docs/src/contributing.md Outdated Show resolved Hide resolved
@navidcy navidcy merged commit 37fd0de into master Apr 12, 2021
@navidcy navidcy deleted the ncc/contributors-guide-patch branch April 26, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrodiePearson BrodiePearson BrodiePearson approved these changes

Assignees
No one assigned
Labels
📔 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidcy @BrodiePearson