Optimize calcF! in examples with stochastic forcing #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If that works, that's awesome! |
glwagner
reviewed
Apr 12, 2021
|
|
||
| Fh .= ArrayType(dev)(ξ) .* sqrt.(forcing_spectrum) | ||
|
|
||
| Fh .= sqrt.(forcing_spectrum) .* exp(2π * im * random_uniform(eltype(grid))) ./ sqrt(clock.dt) |
There was a problem hiding this comment.
Looks good :-D
Unfortunately you may need different functions for Fh::Array and Fh::CuArray, because you may need to use CUDA.sqrt?
There was a problem hiding this comment.
OK, there are some still some issues which I will fix.
But on the other hand, CUDA.sqrt() wasn't required previously... why it should be now? Even before forcing_spectrum could be a CuArray...
There was a problem hiding this comment.
Oh, I guess you're right:
julia> using CUDA
julia> a = CuArray(rand(3))
3-element CuArray{Float64,1}:
0.3974296213138291
0.46740283369767677
0.5039702920081996
julia> b = sqrt.(a)
3-element CuArray{Float64,1}:
0.6304201942465272
0.6836686578289785
0.7099086504672272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223.