Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependencies #43

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Reduce dependencies #43

merged 5 commits into from
Jan 9, 2020

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Jan 4, 2020

I removed PyPlot, Printf, and Coverage from main package deps and moved them in examples.

@glwagner, I think it's counterintuitive that people need to load, e.g., FourierFlows, FFTW, etc in a script, e.g., here:

using FourierFlows, PyPlot, JLD2, Printf, Random, FFTW
using Random: seed!

Since these packages are deps of GeophysicalFlows.jl, I think that something like

using GeophysicalFlows, PyPlot

import GeophysicalFlows.TwoDTurb

should be the only thing we expect the users to do. What do you think?

@navidcy navidcy requested a review from glwagner January 4, 2020 00:41
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files           6        6           
  Lines         518      518           
=======================================
  Hits          511      511           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682328f...2311663. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 4, 2020

Pull Request Test Coverage Report for Build 328

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.649%

Totals Coverage Status
Change from base Build 324: 0.0%
Covered Lines: 1533
Relevant Lines: 1554

💛 - Coveralls

@navidcy navidcy merged commit f7cb2ea into master Jan 9, 2020
@navidcy navidcy deleted the ReduceDependencies branch January 22, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants