Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes module name from TwoDTurb to TwoDNavierStokes #58

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Changes module name from TwoDTurb to TwoDNavierStokes #58

merged 1 commit into from
Mar 19, 2020

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Mar 18, 2020

addresses #44

@navidcy navidcy requested a review from glwagner March 18, 2020 22:21
@codecov
Copy link

codecov bot commented Mar 18, 2020 •
edited
Loading

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files           6        6           
  Lines         510      510           
=======================================
  Hits          503      503           
  Misses          7        7
Impacted Files Coverage Δ
src/GeophysicalFlows.jl 100% <ø> (ø) ⬆️
src/twodnavierstokes.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81e8a3...d057feb. Read the comment docs.

glwagner
glwagner approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@navidcy navidcy merged commit 40e6d05 into master Mar 19, 2020
@navidcy navidcy deleted the RenameTwoDTurb branch March 19, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidcy @glwagner