Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs in MultilayerQG for nlayers=1 #80

Merged
merged 13 commits into from
May 27, 2020
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented May 26, 2020

also it adds test_mqg_rossbywave that checks the evolution of a Rossby wave superimposed on a constant zonal flow U

@navidcy navidcy requested a review from glwagner May 26, 2020 12:17
@navidcy navidcy linked an issue May 26, 2020 that may be closed by this pull request
@navidcy navidcy added the 🐞 bug Something isn't working label May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #80 into master will decrease coverage by 0.47%.
The diff coverage is 94.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   98.63%   98.15%   -0.48%     
==========================================
  Files           6        6              
  Lines         511      542      +31     
==========================================
+ Hits          504      532      +28     
- Misses          7       10       +3     
Impacted Files Coverage Δ
src/multilayerqg.jl 95.14% <94.50%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f34068...60441d1. Read the comment docs.

Copy link
Member Author

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed by @glwagner via zoom

@navidcy navidcy changed the title Fixes bug in MultilayerQG for nlayers=1 Fixes bugs in MultilayerQG for nlayers=1 May 27, 2020
@navidcy navidcy merged commit 95e626f into master May 27, 2020
@navidcy navidcy deleted the FixSingleLayerMultiLayerQG branch June 2, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultilayerQG with nlayer=1 is buggy
2 participants