Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPUify BarotropicQGQL Module #83

Merged
merged 3 commits into from
May 29, 2020
Merged

GPUify BarotropicQGQL Module #83

merged 3 commits into from
May 29, 2020

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented May 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #83 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   91.51%   91.48%   -0.03%     
==========================================
  Files          20       20              
  Lines        1367     1363       -4     
==========================================
- Hits         1251     1247       -4     
  Misses        116      116              
Impacted Files Coverage Δ
examples/barotropicqgql_betaforced.jl 0.00% <ø> (ø)
src/barotropicqgql.jl 100.00% <100.00%> (ø)
test/runtests.jl 96.82% <100.00%> (-0.05%) ⬇️
test/test_barotropicqgql.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248b769...7dfb701. Read the comment docs.

@navidcy
Copy link
Member Author

navidcy commented May 28, 2020

@glwagner this is the last module to be GPUified. After merging we bump up to v0.5.0.
Exciting times.

@navidcy navidcy requested a review from glwagner May 28, 2020 08:48
Copy link
Member Author

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glwagner and @navidcy reviewed this together via zoom; they required no further changes.

@navidcy navidcy merged commit 99ca46e into master May 29, 2020
@navidcy navidcy deleted the GPUifyBarotropicQGQL branch May 29, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant