Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes + Generalization of MultilayerQG.Problem() #86

Merged
merged 9 commits into from
May 29, 2020

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented May 29, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #86 into master will increase coverage by 0.20%.
The diff coverage is 99.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   91.54%   91.74%   +0.20%     
==========================================
  Files          20       20              
  Lines        1372     1369       -3     
==========================================
  Hits         1256     1256              
+ Misses        116      113       -3     
Impacted Files Coverage Δ
examples/barotropicqgql_betaforced.jl 0.00% <0.00%> (ø)
examples/multilayerqg_2layer.jl 0.00% <ø> (ø)
src/twodnavierstokes.jl 100.00% <ø> (ø)
src/barotropicqg.jl 100.00% <100.00%> (ø)
src/barotropicqgql.jl 100.00% <100.00%> (ø)
src/multilayerqg.jl 99.56% <100.00%> (+<0.01%) ⬆️
test/test_barotropicqg.jl 100.00% <100.00%> (ø)
test/test_barotropicqgql.jl 100.00% <100.00%> (ø)
test/test_multilayerqg.jl 100.00% <100.00%> (+1.17%) ⬆️
test/test_twodnavierstokes.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5f6bb...a8ce6dc. Read the comment docs.

@@ -18,7 +18,7 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
[compat]
CuArrays = "^1, ^2"
FFTW = "^1"
FourierFlows = "^0.4"
FourierFlows = "≥0.4.5, ^0.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap; that's the version with the updated plan_flows_rfft.

@navidcy navidcy merged commit 20b5f8f into master May 29, 2020
@navidcy navidcy deleted the Fixes branch May 29, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants