Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscreen window position (#873) #1060

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Fix fullscreen window position (#873) #1060

merged 1 commit into from
Dec 8, 2016

Conversation

spasche
Copy link
Contributor

@spasche spasche commented Dec 5, 2016

From my testing on a Fedora 25 (Gnome 3.22) system, it looks like placing the window in fullscreen from the idle callback is too soon and always places the window on monitor 0 (left one).
If gtk_window_fullscreen() is called from the "map-event" event, it places the window on the same monitor where the window was.
I didn't experience the black border issue mentioned in the previous comment. Using a signal instead of the idle callback means we don't need to track the event source identifier, which removes some code.

I'd be happy if somebody could test this on other environments (non Gnome, or pre-3.22 versions).

Put the window in fullscreen after it is mapped to have it appear on the same monitor.
@antenore
Copy link
Member

antenore commented Dec 5, 2016

Thanks a lot Sylvain!

I'll test it in the next days on some different WMs.

@antenore
Copy link
Member

antenore commented Dec 5, 2016

#124 #241 #873

@antenore
Copy link
Member

antenore commented Dec 5, 2016

Tested on Xfce 4.12 (xfwm4), Gnome 3.18.2 and i3wm on FreeBSD.
In some hours I'll do some other tests, but for me can be merged.

@giox069 what do you think? How is on Unity and Gnome Shell?

@antenore antenore added this to the v1.2.1 milestone Dec 6, 2016
@antenore
Copy link
Member

antenore commented Dec 8, 2016

@giox069 I'm merging this, it behave correctly in all the scenarios I've tested.
@spasche Remember me to add your name in the AUTHORS and remmina_about.glade files before the next release.

@antenore antenore merged commit 857759b into FreeRDP:next Dec 8, 2016
@spasche
Copy link
Contributor Author

spasche commented Dec 8, 2016

Great! Thanks for testing and merging.

@spasche spasche deleted the issue873_fullscreen_wrong_monitor branch December 8, 2016 20:34
@giox069
Copy link
Contributor

giox069 commented Dec 8, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants