Fix fullscreen window position (#873) #1060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing on a Fedora 25 (Gnome 3.22) system, it looks like placing the window in fullscreen from the idle callback is too soon and always places the window on monitor 0 (left one).
If gtk_window_fullscreen() is called from the "map-event" event, it places the window on the same monitor where the window was.
I didn't experience the black border issue mentioned in the previous comment. Using a signal instead of the idle callback means we don't need to track the event source identifier, which removes some code.
I'd be happy if somebody could test this on other environments (non Gnome, or pre-3.22 versions).