Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDP plugin update client main loop to new API #726

Merged
merged 1 commit into from
Jan 16, 2016

Conversation

akallabeth
Copy link
Member

No description provided.

@giox069
Copy link
Contributor

giox069 commented Jan 15, 2016

@akallabeth many many thanks for these patches.
I will merge as soon as possible.
@akallabeth Do you think that some problems reported by users (RDP disconnections, issues #723 #710) were caused by Remmina using the old api ?
@antenore: I checked this PR against the freerdp version on the Ubuntu PPA (december 18 2015) and it seems to be ok. So we could merge.

@antenore
Copy link
Member

It's fine for me.
Thanks for the patches!

@giox069
Copy link
Contributor

giox069 commented Jan 15, 2016

@antenore... never mind. I have problems with input (mouse & keyboard). I will do further testing tomorrow. Maybe we need also an upgrade to freerdp in the PPA.

@giox069 giox069 merged commit f5be816 into FreeRDP:next Jan 16, 2016
@giox069
Copy link
Contributor

giox069 commented Jan 16, 2016

I merged and then readded mouse/keyboard handling with another commit.
Thank you again @akallabeth.

@akallabeth akallabeth deleted the new_main_loop branch January 16, 2016 13:11
@akallabeth
Copy link
Member Author

@giox069 No, I've encountered the disconnects after that too. There also seems to be an issue with the sound channel, I get crashes from time to time (looks like the argument struct is invalid at some point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants