Skip to content

committer opt-in confirmed by mail, Spanish translation, review fixes

Latest

Choose a tag to compare

@dlangille dlangille released this 20 Nov 22:48
· 5 commits to main since this release

What's changed

Security and correctness (November 2026 review, continued)

  • Committer opt-in now needs confirming from the mailbox (S14). Before, anyone logged in could opt any committer login into the sanity-test mail. Now a new or changed opt-in stays pending until someone uses the link mailed to <login>@FreeBSD.org. The new page committer-notify.php is where that link goes, and also where the link at the end of every sanity-test mail goes. Opening the link changes nothing; only its Confirm, Refuse and Stop buttons do. Committers who are already opted in see no change. (abce498)
  • delete-account.php: an account is deleted only with a valid CSRF token (www-n12-3).
  • watch-list.php, commit-flag.php: redirects to other sites, or to targets containing control characters, are refused (www-n12-5).
  • pkg_upload.php: "Port from your watch lists" shows only your own watch lists (www-n12-4).
  • configuration/virtualhost-common.conf.sample: the 404 for dotfiles, *.inc and ~ files now applies only when the file exists on disk. Port pages for ports-tree files such as korean/Makefile.inc or a top-level .gitignore work again (www-n12-1).
  • search.php: the search-log warning appears inside the page instead of before it (www-a-1).
  • sanity_test_failures.php: pages by commit again, one row per commit (www-a-2).

Other changes

  • watch.php: the hover text on the watch-list icon now names the list being shown, not the default lists.
  • watch-list-maintenance.php: no PHP warning on Empty All.
  • Encoding Errors icon and its FAQ entry now say which characters get removed today.
  • faq.php: explains the rename from FreeBSD to FreeBSD-ports / FreeBSD-base; "base" is no longer offered for translation.
  • other-copyrights.php: the page source now gives the freshsource-www and fp-listen versions, for the all-sites versions page.
  • Search-gate log lines now go to LOCAL3 instead of /var/log/messages (openlog() is called before logging). They are now logged at LOG_INFO, not LOG_NOTICE.
  • configuration/database.php.sample: a failed database connection now logs its reason (too many clients, refused, authentication, ...) on the syslog line.

Translations

Upgrade notes

  • Database: run updates-2026-11-16-committer-notify-confirm.ddl from database-schema, as postgres, on each database before installing. It adds the token and token_created columns that committer-opt-in.php and committer-notify.php need.
  • nginx: copy the new location ~ (/\.|\.inc$|~$) block from virtualhost-common.conf.sample into each host's vhost, then nginx -t and reload.
  • Configuration (optional): to log why a database connection failed, copy the new else branch from database.php.sample into the host's configuration/database.php.
  • i18n: run scripts/i18n-compile.sh (this release adds a new locale, es_ES), then service php_fpm reload.
  • Logging: search-gate challenge lines now reach /var/log/freshports/freshports.log (LOCAL3) at INFO. Check that logcheck rules or log watching for "search gate challenge" still match there.

Files added

  • include/committer-notify.php
  • www/committer-notify.php
  • locale/es_ES/LC_MESSAGES/freshports.po

Files deleted or renamed

None.

Full Changelog: 2.16.33...2.16.34