Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Overlay triggers for ANY user interacting with Waterfall #181

Closed
csharpfritz opened this issue Sep 5, 2023 · 1 comment · Fixed by #219
Closed

Bug: Overlay triggers for ANY user interacting with Waterfall #181

csharpfritz opened this issue Sep 5, 2023 · 1 comment · Fixed by #219
Assignees
@csharpfritz
Labels
bug Something isn't working
Milestone
Milestone 2

Comments

@csharpfritz
Copy link
Contributor

This is an authorization issue, where any user regardless of login state can change the overlay by interacting with the waterfall.

We may want to connect this somehow with a token
@csharpfritz csharpfritz added the bug Something isn't working label Sep 5, 2023
@csharpfritz csharpfritz added this to the Milestone 2 milestone Sep 5, 2023
@csharpfritz
Copy link
Contributor Author

I wonder if this should be as simple as "only trigger the overlay for the same user who selected something on the waterfall"

@csharpfritz csharpfritz self-assigned this Sep 25, 2023
csharpfritz added a commit to csharpfritz/TagzApp that referenced this issue Sep 25, 2023
@csharpfritz
Fixes FritzAndFriends#181
38ba921
@csharpfritz csharpfritz mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csharpfritz csharpfritz

Labels
bug Something isn't working
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging a pull request may close this issue.

Anchored overlay to the current logged in user csharpfritz/TagzApp
1 participant
@csharpfritz