Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add StartAsync and StopAsync methods to ISocialMediaProvider #94

Closed
csharpfritz opened this issue Aug 15, 2023 · 1 comment
Closed

Enhancement: Add StartAsync and StopAsync methods to ISocialMediaProvider #94

csharpfritz opened this issue Aug 15, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
Milestone 3

Comments

@csharpfritz
Copy link
Contributor

Social Media Providers should not start processes in the constructor nor should they only end processes in a Dispose or Finalizer
@csharpfritz csharpfritz added enhancement New feature or request help wanted Extra attention is needed labels Aug 15, 2023
@csharpfritz csharpfritz added this to the Milestone 2 milestone Aug 15, 2023
@csharpfritz csharpfritz modified the milestones: Milestone 2, Milestone 3 Sep 19, 2023
csharpfritz added a commit to csharpfritz/TagzApp that referenced this issue Sep 21, 2023
@csharpfritz
Added StartAsync to SocialMediaProviders - fixes FritzAndFriends#94
f627fc0
csharpfritz added a commit to csharpfritz/TagzApp that referenced this issue Sep 26, 2023
@csharpfritz
Added StartAsync to SocialMediaProviders - fixes FritzAndFriends#94
86921bc 
Applying formatting changes through GitHub Actions

Merged

Fixed brackets

WIP

Applying formatting changes through GitHub Actions

WIP

Marked ProviderId as required in Message (FritzAndFriends#217)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Anchored overlay to the current logged in user (FritzAndFriends#219)

Updated docs, slight UI tweaks (FritzAndFriends#220)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Applying formatting changes through GitHub Actions

Removed the YouTubeScraper

Fixed repeated emotes in TwitchChat

Now retrieving YouTube events for the current user

Now fetching channel information

Applying formatting changes through GitHub Actions

Fixed missing implementation

Applying formatting changes through GitHub Actions
@csharpfritz
Copy link
Contributor Author

StartAsync method is available on the ISocialMediaProvider interface. May need more work to connect to the provider configuration to activate and deactivate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
Milestone 3
Development

No branches or pull requests
1 participant
@csharpfritz