Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Code Formatting Action #191

Merged

Conversation

degenone
Copy link
Contributor

@degenone degenone commented Sep 6, 2023

I believe the issue with the last PR was that since it was just a PR, it was not granted full write permissions (which is understandable) and was not able to push the formatting commit.

To showcase the workflow I create foo_main -branch on my fork and changed the workflow triggers accordingly and then made a PR to that branch.

  1. the PR
  2. on pull request workflow run
  3. on push workflow run

Closes #131

@Stelzi79
Copy link
Contributor

Stelzi79 commented Sep 6, 2023

Please also add a needs: [code-formatting] to todos-to-issues.yml. This PR makes a nice addition to this workflow!

@degenone
Copy link
Contributor Author

degenone commented Sep 6, 2023

Please also add a needs: [code-formatting] to todos-to-issues.yml.

When I add this, my VSCode complains:

The workflow must contain at least one job with no dependencies.
Value 'code-formatting' is not valid

@Stelzi79
Copy link
Contributor

Stelzi79 commented Sep 7, 2023

Please also add a needs: [code-formatting] to todos-to-issues.yml.

When I add this, my VSCode complains:

The workflow must contain at least one job with no dependencies.
Value 'code-formatting' is not valid

Hm I thought that works across workflows ... I will investigate that.

@Stelzi79
Copy link
Contributor

Stelzi79 commented Sep 7, 2023

Please add

  workflow_run:
    workflows: ["Run Tests"]
    branches: [main]
    types: 
      - completed

in the on: section. (See the accepted answer in this Dependencies Between Workflows on Github Actions SO question.)

@csharpfritz csharpfritz merged commit 4ca952e into FritzAndFriends:main Sep 7, 2023
@csharpfritz
Copy link
Contributor

Thank you for the research and implementing this... it helps to keeps us all on a consistent code-style.

@degenone degenone deleted the feature_Formatting_Action branch September 7, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Code Style Check GitHub Action
3 participants