Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider management UI #206

Merged
merged 53 commits into from
Oct 17, 2023
Merged

Conversation

NapalmCodes
Copy link
Contributor

@NapalmCodes NapalmCodes commented Sep 15, 2023

Provides functionality that maps a view model (Implementation of IProviderConfigurationViewModel) for a provider to a provider configuration UI accordion section for setting the necessary values. This is currently in MVP state and some recommended follow-up items are listed below for added polish:

  • Stronger form validation on server (attribute based approach maybe?)
  • Password obscurity UI features (toggle display/no-display of sensitive information)
  • Alert the system of updated provider configuration at runtime (to avoid restart to re-load the settings)
  • Alert the system of providers being activated/deactivated at runtime (to avoid restart to re-load the settings)
  • Form UI control to handle header entry (i.e.: add as many key value pair inputs as you need vs raw json currently used)
  • Refactor for stronger typing capabilities. Currently heavily utilizing strings there are opportunities to make this better
  • In-Memory capability (@csharpfritz and I chatted and decided this wasn't ultra important)

Other features to mention currently implemented:

  • Override description with database value and/or simply provide in provider

@NapalmCodes NapalmCodes marked this pull request as draft September 28, 2023 20:00
NapalmCodes and others added 23 commits October 9, 2023 13:23
@NapalmCodes NapalmCodes marked this pull request as ready for review October 16, 2023 17:05
@csharpfritz csharpfritz merged commit 2240c5d into FritzAndFriends:main Oct 17, 2023
@NapalmCodes NapalmCodes deleted the provider-ui branch October 17, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants