Minor DOM Fixes #392
Merged
Minor DOM Fixes #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignore JetBrains settings folder - Apparently an invalid character was provided after the page directive - Added closing div tag to Moderation.cshtml - Added closing select to blocked users - Added closing carrot for div
|
The TagzApp.Web project is the older project that is being deprecated in favor of the Blazor projects. I’ll review and we can merge tomorrow on stream. Thanks!JeffOn Mar 6, 2024, at 17:09, Badger ***@***.***> wrote:Wasn't sure if there needs to be an official issue for this.
Ignore JetBrains settings folder
Apparently an invalid character was provided after the page directive?
Added closing div tag to Moderation.cshtml
Added closing select to blocked users
Added closing carrot for div in waterfall
You can view, comment on, or merge this pull request online at:
#392
Commit Summary
d4e4d9f Minor Fixes
File Changes (5 files)
M
.gitignore
(3)
M
src/TagzApp.Blazor/Components/Pages/_Waterfall.razor
(2)
M
src/TagzApp.Web/Pages/BlockedUsers.cshtml
(7)
M
src/TagzApp.Web/Pages/Moderation.cshtml
(2)
M
src/TagzApp.Web/Pages/Overlay.cshtml
(2)
Patch Links:
https://github.com/FritzAndFriends/TagzApp/pull/392.patch
https://github.com/FritzAndFriends/TagzApp/pull/392.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
That would make sense! If this is the case, then there's an issue where the |
|
Thank you for the help identifying those markup issues. Changes merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure if there needs to be an official issue for this.