Add test that show tx pool consistency can't be reached #1187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this test fails at
Bob
because nodes score becomes too low to actually gossip with each other. They seem to be penalized for "mesh message delivery". They should not be being penalized so this is a bug @leviathanbeakIf I manually set the penalty thresholds to super low then this test fails at the producer coming back online. This is the original issue the test was meant to show. This happens because "gossipsub" only tries to deliver messages for 3 heartbeats. So we can't rely on "gossipsub" to get the tx pools to consistency.
Note the solution to the tx pool consistency should be done at the app level not the network. So each tx pool should diff each others ids and then exchange messages each other don't have. This could be on a pretty slow loop.
Related issue #1049